Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Dec 13, 2025

No description provided.

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 4 suggestions posted. Overall the SensoryFeedback plumbing looks cohesive; the notes focus on a couple of UIKit edge cases and platform-behavior mismatches.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye force-pushed the feature/sensory_feedback branch from 889313b to 8d98525 Compare December 13, 2025 12:35
@Kyle-Ye Kyle-Ye merged commit 75dff0e into main Dec 13, 2025
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/sensory_feedback branch December 13, 2025 14:16
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.45%. Comparing base (c5070c9) to head (17cef50).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rol/SensoryFeedback/SensoryFeedbackGenerator.swift 0.00% 69 Missing ⚠️
...Feedback/AppKit/AppKitFeedbackImplementation.swift 0.00% 16 Missing ⚠️
...View/Control/SensoryFeedback/SensoryFeedback.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #668       +/-   ##
===========================================
+ Coverage   13.88%   28.45%   +14.56%     
===========================================
  Files         556      583       +27     
  Lines       32418    35121     +2703     
===========================================
+ Hits         4502     9992     +5490     
+ Misses      27916    25129     -2787     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants