Add Event API#13
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 71.85% 74.19% +2.33%
==========================================
Files 56 62 +6
Lines 1439 1519 +80
==========================================
+ Hits 1034 1127 +93
+ Misses 405 392 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce the core Event type hierarchy:
Eventprotocol (Identifiable,id/phase/timestamprequirements) +EventPhaseenum (.began/.active/.ended/.failed).EventIDstruct —Hashable,CustomStringConvertible,Sendablewrapper aroundInt.SpatialEventprotocol (Event & LocationContaining).ScrollEventprotocol withdelta/acceleratedDelta, plusConcreteScrollEventconcrete struct.MouseEventandTouchEventconcrete spatial events;MouseEvent.ButtonRawRepresentablestruct (.primary/.secondary/.tertiary).LocationContainingtopublicand addIdentifiableLocation<ID>.Adds compatibility tests for
EventID,MouseEvent,TouchEvent,ConcreteScrollEvent. The description tests are parametric with exact==assertions against the fullNestedCustomStringConvertibleoutput, covering everyEventPhasecase.Test plan
xcodebuild test -only-testing:OpenGesturesTestson iPhone 17 Pro / iOS 26.2 SimulatorOPENGESTURES_COMPATIBILITY_TEST=0 xcodebuild test -only-testing:OpenGesturesCompatibilityTestson the same simulatorOPENGESTURES_COMPATIBILITY_TEST=1 OPENGESTURES_USE_LOCAL_DEPS=1 xcodebuild test -only-testing:OpenGesturesCompatibilityTestson the same simulator (requires matchingDarwinPrivateFrameworksbranch)