Fix CI failures across all platforms#1
Merged
Merged
Conversation
Kyle-Ye
force-pushed
the
fix-ci-failures
branch
4 times, most recently
from
4a941d4 to
a215143
Compare
Member
Author
Ubuntu: - Add SwiftCorelibs CoreFoundation headers with -isystem for non-Darwin - Add NSInteger/NSUInteger typedefs for non-Darwin in OGFBase.h - Replace CoreGraphics imports with OpenCoreGraphicsShims - Add OpenCoreGraphics package dependency macOS: - Remove unnecessary darwin_setup_build.sh step and DPF env vars - Fix unused public import Foundation in RunLoopUpdateDriver - Fix GestureComponentController missing @unchecked Sendable restatement iOS: - Remove unnecessary darwin_setup_build.sh step and DPF env vars - Remove -workspace flag and use correct scheme name for xcodebuild Compatibility tests: - Use GF/update.sh instead of swift package update-xcframeworks - Pin DARWINPRIVATEFRAMEWORKS_TARGET_RELEASE=2025 in gf_setup.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-isystemfor non-Darwin),NSInteger/NSUIntegertypedefs inOGFBase.h, and replaceCoreGraphicsimports withOpenCoreGraphicsShimsdarwin_setup_build.shstep and DPF env vars; fix unusedpublic import Foundationwarning-as-error-workspaceflag from xcodebuild (not needed for SPM packages)GF/update.sh(pinnedTARGET_RELEASE=2025) instead ofswift package update-xcframeworksTest plan