Skip to content

Conversation

@Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Sep 6, 2025

Summary

  • Cleaned up metadata debug code by removing obsolete comments
  • Improved field enumeration for structs and classes using .continueAfterUnknownField
  • Added comprehensive test coverage for classes with unknown fields
  • Enhanced code readability with proper hex offset formatting

Test plan

  • Existing metadata debug tests pass
  • New test for unknown fields handling
  • Code builds successfully

- Remove obsolete comments about field enumeration options
- Use .continueAfterUnknownField for struct and class field enumeration
- Add comprehensive test for classes with unknown fields
- Add hex formatter extension for offset display
@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.81%. Comparing base (989275d) to head (b767453).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...urces/OpenAttributeGraphShims/Metadata+Debug.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #182   +/-   ##
=====================================
  Coverage   4.81%   4.81%           
=====================================
  Files         28      28           
  Lines        831     831           
=====================================
  Hits          40      40           
  Misses       791     791           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 9792105 into main Sep 6, 2025
5 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/metadata-debug-improvements branch September 6, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants