Skip to content

Update for OpenSwiftUI observation support #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 3 commits into from
Sep 6, 2025
Merged

Update for OpenSwiftUI observation support #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a896e5
Fix subgraph2 release issu
Kyle-Ye Sep 6, 2025
5b66d81
Add OAGGraphCurrentAttributeWasModified
Kyle-Ye Sep 6, 2025
aac3594
Update AG dependency
Kyle-Ye Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Sources/OpenAttributeGraphCxx/Attribute/OAGAttribute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,16 @@

const OAGAttribute OAGAttributeNil = OAGAttribute(OAG::AttributeID::Kind::Null);

OAGAttribute OAGGraphGetCurrentAttribute() {
OAGAttribute OAGGraphGetCurrentAttribute(void) {
// TODO
return OAGAttributeNil;
}

bool OAGGraphCurrentAttributeWasModified(void) {
// TODO
return false;
}

namespace {
OAGAttribute create_offset_attribute(OAGAttribute attribute, uint64_t offset, std::optional<uint64_t> size) {
// TODO
Expand Down
8 changes: 8 additions & 0 deletions Sources/OpenAttributeGraphCxx/include/OpenAttributeGraph/OAGAttribute.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

OAG_ASSUME_NONNULL_BEGIN

OAG_IMPLICIT_BRIDGING_ENABLED

OAG_EXTERN_C_BEGIN

OAG_EXPORT
Expand All @@ -27,6 +29,10 @@ OAG_EXPORT
OAG_REFINED_FOR_SWIFT
OAGAttribute OAGGraphGetCurrentAttribute(void);

OAG_EXPORT
OAG_REFINED_FOR_SWIFT
bool OAGGraphCurrentAttributeWasModified(void);

OAG_EXPORT
OAG_REFINED_FOR_SWIFT
OAGAttribute OAGGraphCreateOffsetAttribute(OAGAttribute attribute, long offset) OAG_SWIFT_NAME(OAGAttribute.create(self:offset:));
Expand Down Expand Up @@ -161,6 +167,8 @@ void OAGGraphWithUpdate(

OAG_EXTERN_C_END

OAG_IMPLICIT_BRIDGING_DISABLED

OAG_ASSUME_NONNULL_END

#endif /* OAGAttribute_h */
Expand Down