Skip to content

Conversation

@jcmosc
Copy link
Contributor

@jcmosc jcmosc commented Aug 24, 2025

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.81%. Comparing base (bdf2352) to head (bd04ebe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #172      +/-   ##
========================================
- Coverage   5.49%   4.81%   -0.68%     
========================================
  Files         25      28       +3     
  Lines        655     830     +175     
========================================
+ Hits          36      40       +4     
- Misses       619     790     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Kyle-Ye Kyle-Ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Part of the API has been added.
  2. For added API, please add compatibility test case to avoid future link error.
  3. Please rebase to use OAG instead of OG.

@jcmosc jcmosc force-pushed the subgraph-interface branch from e544965 to 0fa3d00 Compare September 6, 2025 18:54
@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Sep 7, 2025

I have updated the branch to fix the CI error. Also create and merged the DPF PR.

Since both ConditionTrait and GraphEnvironmentTrait's isRecursive are true, we can omit the ConditionTrait in ChildrenTests.

@Kyle-Ye Kyle-Ye self-requested a review September 7, 2025 03:27
@Kyle-Ye Kyle-Ye merged commit 2a615c6 into OpenSwiftUIProject:main Sep 7, 2025
5 checks passed
@jcmosc jcmosc deleted the subgraph-interface branch September 7, 2025 13:29
@jcmosc
Copy link
Contributor Author

jcmosc commented Sep 7, 2025

@Kyle-Ye Thanks for fixing the last issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants