add LED and button wiring circuit diagram #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTrainGoes
requested changes
Oct 27, 2025
Contributor
There was a problem hiding this comment.
I would prefer that we breakout the LED and buttons section if we are going to add basic sections for them.
Contributor
There was a problem hiding this comment.
Can these be split up into two separate file? One for Player LED one for a button?
Player LED looks fine,
For the button example can we change that to include an example of one button and multiple buttons, adding a note that the grounds can be chained.
TheTrainGoes
approved these changes
Oct 29, 2025
Contributor
TheTrainGoes
left a comment
TheTrainGoes
left a comment
There was a problem hiding this comment.
Looks good - thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.