Fix add missing landmark roles for accessibility #1299
Draft
Stef-Rousset wants to merge 9 commits intodevelopfrom
Draft
Fix add missing landmark roles for accessibility #1299Stef-Rousset wants to merge 9 commits intodevelopfrom
Stef-Rousset wants to merge 9 commits intodevelopfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR improves accessibility by adding missing landmark roles on:
role="banner",role="main",role="contentinfo"This PR is related to the audit of Angers city(page 21 and 22), and is related to criterias 1.3.1, 2.41 and 4.1.2 from WCAG.
📌 Related Issues
Testing
Open your devtools, navigate in the app and check if header, main and footer have their appropriate role.
📷 Screenshots (optional)