Fix flag modals to improve accessibility#1275
Draft
Stef-Rousset wants to merge 2 commits intodevelopfrom
Draft
Conversation
bb46f42 to
67a6db7
Compare
67a6db7 to
eafcdd1
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @xabier feel free to chime in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR updates flag modals to improve accessibility, by adding:
fieldsetandlegendon radio buttonsforandidattributes on radio buttonsforandidattributes of the textareaThis PR is issued from the audit of Angers city (page 92 and 93), and corresponds to criterias 1.3.1 and 3.3.2 from WCAG
📌 Related Issues
Testing
📷 Screenshots (optional)
Radio buttons

Textarea
