fix: Block Users that got an invalid nickname#44
Merged
Quentinchampenois merged 5 commits intomasterfrom May 7, 2025
Merged
Conversation
Quentinchampenois
previously approved these changes
May 5, 2025
AyakorK
dismissed stale reviews from Quentinchampenois and Stef-Rousset
via
f0803bb
Quentinchampenois
requested changes
May 5, 2025
Contributor
Quentinchampenois
left a comment
Quentinchampenois
left a comment
There was a problem hiding this comment.
After another review, I think we should prevent raising exception without catching it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where users with an invalid nickname (from a few years ago) could not be blocked, causing the task to crash. To address this, we updated the user's nickname and stored the previous one in the
extended_datafield, ensuring that any future issues related to the nickname are avoided.