fix: Move the helper loading #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentinchampenois
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the helper loading method out of
to_preparebecause it was loading the helper before the application was fully initialized. This caused issues whenDecidim::Controllerwas not yet loaded, leading to application crashes.We identified this issue after removing an
extendslinked to theAccountController. Previously, thisextendsensured, with some reasons that we ignore for now, thatDecidim::Controllerwas initialized in the correct order, allowing the application to function properly after the loading of the gallery module.Once we removed this now unnecessary
extends, we encountered a crash that completely prevented the application from starting.