Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build_app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ on:
inputs:
ruby_version:
description: 'Ruby Version'
default: "3.2.2"
default: "3.3.4"
type: string
required: false
node_version:
description: 'Node version'
default: '18.17.1'
default: '22.14.0'
required: false
type: string
jobs:
Expand Down Expand Up @@ -55,6 +55,10 @@ jobs:
- run: bundle exec rake test_app
name: Create test app
shell: "bash"
- run: |
rm -f ./spec/decidim_dummy_app/app/services/dummy_signature_handler.rb
rm -f ./spec/decidim_dummy_app/app/services/dummy_sms_mobile_phone_validator.rb
name: Remove Initiative-dependent dummy files
- run: mkdir -p ./spec/decidim_dummy_app/tmp/screenshots
name: Create the screenshots folder
shell: "bash"
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/ci_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- main
- release/*
- "*-stable"
- "*bump*"
pull_request:
branches-ignore:
- "chore/l10n*"
Expand All @@ -15,8 +16,8 @@ on:

env:
CI: "true"
RUBY_VERSION: 3.2.2
NODE_VERSION: 18.17.1
RUBY_VERSION: 3.3.4
NODE_VERSION: 22.14.0

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
inputs:
ruby_version:
description: 'Ruby Version'
default: "3.2.2"
default: "3.3.4"
required: false
type: string
test_command:
Expand Down
17 changes: 11 additions & 6 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,25 @@
inherit_from: https://raw.githubusercontent.com/decidim/decidim/release/0.28-stable/.rubocop.yml
plugins:
- rubocop-factory_bot

inherit_from:
- .rubocop_ruby.yml
- .rubocop_rails.yml

AllCops:
TargetRubyVersion: 3.3
Include:
- "**/*.rb"
- "**/*.rake"
- "**/*.ru"
- "**/Gemfile"
- "**/Rakefile"
Exclude:
- "development_app/**/*"
- "spec/decidim_dummy_app/**/*"
- "bin/**/*"
- "node_modules/**/*"
- "db/schema.rb"
- "vendor/**/*"
- "spec/decidim_dummy_app/**/*"
- "development_app/**/*"

RSpec/FilePath:
RSpec/DescribeClass:
Exclude:
- "spec/serializers/user_export_serializer_spec.rb"
- spec/system/*
97 changes: 97 additions & 0 deletions .rubocop_rails.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
plugins:
- rubocop-rails

Rails:
Enabled: true

Rails/ActionFilter:
Include:
- decidim-*/app/controllers/**/*.rb

Rails/ContentTag:
Enabled: false

Rails/CreateTableWithTimestamps:
Enabled: false

Rails/EnumUniqueness:
Include:
- decidim-*/app/models/**/*.rb

Rails/Exit:
Include:
- decidim-*/app/**/*.rb
- decidim-*/config/**/*.rb
- decidim-*/lib/**/*.rb
Exclude:
- decidim-*/lib/**/*.rake

Rails/FindBy:
Include:
- "**/*.rb"

Rails/FindEach:
Include:
- decidim-*/app/models/**/*.rb

Rails/HasAndBelongsToMany:
Include:
- decidim-*/app/models/**/*.rb

Rails/HasManyOrHasOneDependent:
Include:
- decidim-*/app/models/**/*.rb

Rails/InverseOf:
Enabled: false

Rails/LexicallyScopedActionFilter:
Include:
- decidim-*/app/controllers/**/*.rb

Rails/NotNullColumn:
Enabled: false

Rails/Output:
Include:
- decidim-*/app/**/*.rb
- decidim-*/config/**/*.rb
- decidim-*/db/**/*.rb
- decidim-*/lib/**/*.rb
Exclude:
- decidim-core/db/seeds.rb
- decidim-core/lib/decidim/core.rb
- decidim-core/lib/decidim/component_manifest.rb
- decidim-core/lib/decidim/participatory_space_manifest.rb
- decidim-system/db/seeds.rb
- decidim-templates/db/seeds.rb

Rails/OutputSafety:
Enabled: false

Rails/Pluck:
Enabled: false

Rails/RakeEnvironment:
Enabled: false

Rails/ReadWriteAttribute:
Include:
- decidim-*/app/models/**/*.rb

Rails/ReversibleMigration:
Enabled: false

Rails/ScopeArgs:
Include:
- decidim-*/app/models/**/*.rb

Rails/SkipsModelValidations:
Enabled: true

Rails/Validation:
Include:
- decidim-*/app/models/**/*.rb

FactoryBot/FactoryAssociationWithStrategy:
Enabled: false
Loading