release: half sign up, multiple answers and translations#144
Merged
Quentinchampenois merged 27 commits intomasterfrom Apr 29, 2025
Merged
release: half sign up, multiple answers and translations#144Quentinchampenois merged 27 commits intomasterfrom
Quentinchampenois merged 27 commits intomasterfrom
Conversation
* test: Add specs for user presenter * fix: Set has_tooltip to false for user presenter
* fix: Deactivate vote_weigth in decidim awesome * fix: enhance logs in dev mode * fix: Allow to configure feat using env var
* fix: Export proposals rake task * fix: Export attachments url in proposal serializer * revert: Remove dummy rake task * spec: Ensure attachments_urls key is serialized
* fix: Remove public true in active storage * fix: Change separator in CSV
* feat: Addition of Half Signup * fix: Normalize french locales * fix: Fix the failing account specs (mixing decidim & half_signup) * fix: Ignore missing locales * fix: Update the user model overrided on Half Signup that broke the test
* Backport: fix Half sign up * Change actions/upload-artifact version and add rake task * Add clear duplicated users rake task * add rake task * chore: Fix tests & lint * feat: add Logging utils
* fix: override private_body partial to add condition to show private body * test: add system test * test: update missing keys in i18n tasks file * ci: update upload-artifact action * ci: add imagemagick for tests * ci: update ci again * ci: add chrome version * ci: update ci * ci: updating again
…ltiple-answers Add survey multiple answers module
This reverts commit 7a978c9.
bump: budget booth
…h_update bump: last budget_booth update
bump: Half signup to last release
feat: Add static locales to avoid decidim-awesome issues
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a half sign-up feature with multiple answer options and translations while also adding SMS verification support for phone numbers. Key changes include new database tables and migrations for half sign-up settings and phone attributes, updates to configuration files (secrets, locales, Sidekiq, and initializers), and new service and view components for SMS notifications.
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| db/schema.rb | Updates schema version, adds a new table for half signup auth settings, and phone number columns in users table. |
| db/migrate/* | New migrations to add phone number attributes and create the auth settings table. |
| config/sidekiq.yml | Adds a new scheduled job for archiving users’ phone numbers with a dynamic cron expression. |
| config/secrets.yml, locales, initializers | New configuration for half signup and SMS gateway services and additional locale translations. |
| app/* | New view components and service classes supporting SMS verification and user phone number archiving. |
| Gemfile | Updates gem dependencies and branches for compatibility with half signup features. |
| .github/workflows/ci_cd.yml | Updates CI/CD configuration to install a specific Chrome version and related dependencies. |
Files not reviewed (1)
- .env-example: Language not supported
Comments suppressed due to low confidence (1)
Gemfile:24
- [nitpick] Please confirm that using a temporary branch name for 'decidim-extra_user_fields' is intentional and consistent with your versioning strategy.
gem "decidim-extra_user_fields", git: "https://github.com/OpenSourcePolitics/decidim-module-extra_user_fields.git", branch: "temp/twilio-compatibility-0.27"
Quentinchampenois
approved these changes
Apr 29, 2025
Contributor
Quentinchampenois
left a comment
Quentinchampenois
left a comment
There was a problem hiding this comment.
LGTM
However there is a lot of missing tests compared to code and overrides added to the codebase
- SMSGatewayService
- User Extend
- Archive User Job
- Account show page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.