Merged
Conversation
Closed
luciegrau
approved these changes
Apr 3, 2025
Quentinchampenois
approved these changes
Apr 4, 2025
Contributor
Quentinchampenois
left a comment
There was a problem hiding this comment.
JS condition could have been 👍 :
!localStorage.getItem("pwaInstallPromptSeen")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 Description
The aim of this PR is to deactivate pwa prompt, by setting pwaInstallPromptSeen variable to true in localStorage (cf decidim-core/app/packs/src/sw/a2hs.js which the file where the prompt is launched)
📌 Related Issues
Testing
Go to develop branch and see if you can get the prompt (cf screenshot one). I wasn't able to get it in local env or in docker...
Go back to the PR branch
If you have the prompt, to test this PR, you can follow these steps:
If you don't have the prompt, to test this PR, you can follow these steps:
In local env:
Then, in https://petitions.lecese.fr
localStorage.setItem("pwaInstallPromptSeen", true)(cf screenshot three)📷 Screenshots
ONE =>

TWO =>

THREE =>
