-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select rules based on reference #2070
Conversation
This PR introduces a new option `--reference` that allows users to filter rules base on rule reference. This is useful to evaluate compliance with a particular policy requirement. This feature needs SCAP content to contain reference URI-to-title mapping within the `xccdf:Benchmark` element. The ComplianceAsCode content upstream project started to provide this mapping in the SCAP content recently, starting from 62513c391dc5a3fafd12741bd02565ca0e1e8db2. To support the easier experience with this feature, also a new option `--references` to the `oscap info` module has been added, this option extends the output of the command by listing all available reference names. Fixes: https://issues.redhat.com/browse/RHEL-1479
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Please take a look at my comments.
Instead of a segfault we will produce an error message.
I have fixed the segfault. I have fixed the help text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please review the testing farm failure?
It's the probe_behavior/collect_limit.sh which fails randomly from time to time |
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info.
LGTM.
This PR introduces a new option
--reference
that allows users to filter rules base on rule reference. This is useful to evaluate compliance with a particular policy requirement.This feature needs SCAP content to contain reference URI-to-title mapping within the
xccdf:Benchmark
element. The ComplianceAsCode content upstream project started to provide this mapping in the SCAP content recently, starting from 62513c391dc5a3fafd12741bd02565ca0e1e8db2.To support the easier experience with this feature, also a new option
--references
to theoscap info
module has been added, this option extends the output of the command by listing all available reference names.Fixes: https://issues.redhat.com/browse/RHEL-1479