Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First try at adding remarks to the guide #1755

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented May 14, 2021

Finishing off the last part #1743.

This adds remarks to the guide HTML.

@openscap-ci
Copy link

Can one of the admins verify this patch?

1 similar comment
@openscap-ci
Copy link

Can one of the admins verify this patch?

@jan-cerny
Copy link
Member

@openscap-ci add to whitelist

@Mab879 Mab879 marked this pull request as ready for review September 10, 2021 19:45
@evgenyz
Copy link
Contributor

evgenyz commented Apr 19, 2023

@Mab879 Is it still actual?

@evgenyz
Copy link
Contributor

evgenyz commented Apr 19, 2023

I mean, I don't see any problems with it, but it somehow stuck in the review phase.

@Mab879
Copy link
Member Author

Mab879 commented Jul 7, 2023

This might be useful if we want to do ComplianceAsCode/content#6889

@evgenyz
Copy link
Contributor

evgenyz commented Feb 9, 2024

@Mab879 Is it still relevant?

@Mab879
Copy link
Member Author

Mab879 commented Feb 9, 2024

@Mab879 Is it still relevant?

My comment from July 2023 is still valid.

@evgenyz
Copy link
Contributor

evgenyz commented Feb 9, 2024

Okay, ComplianceAsCode/content#6889 is rather stale as well. But, will it be worked on or not, this particular change won't hurt anyone.

@evgenyz evgenyz merged commit 80daf96 into OpenSCAP:maint-1.3 Feb 9, 2024
18 checks passed
@Mab879 Mab879 deleted the fix_1743 branch February 9, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants