remove geometry transforms from nec-input and add use of just#4
Merged
Conversation
There was a conflict in documentation betweeen the project design and the nec-import crate, and geometry transforms were a part of the nec-import crate when they shouldn't have been. I corrected the documentation, and removed the geometry transforms from the nec-import crate Additionally, I added a justfile to the project to make it easier to run common commands and rebuild the python bindings after create changes. CONTRIBUTING.md and the design documents were updated to reflect these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a conflict in documentation betweeen the project design and the nec-import crate, and geometry transforms were a part of the nec-import crate when they shouldn't have been.
I corrected the documentation, and removed the geometry transforms from the nec-import crate
Additionally, I added a justfile to the project to make it easier to run common commands and rebuild the python bindings after create changes.
CONTRIBUTING.md and the design documents were updated to reflect these changes.