Assembly settings

[wetneb]

Adds the missing packaging configuration @thadguidry.

[thadguidry]

Suggested change

	<includeBaseDirectory>false</includeBaseDirectory>
	<baseDirectory>openrefine-extension-archive</baseDirectory>
	<includeBaseDirectory>true</includeBaseDirectory>

The above suggestion fixes the issue completely. That way it actually also coincides with the installation docs as well quite nicely! In our docs we were telling users themselves to make a top-level folder for the extension and then extract its contents into that. This is a better way. With my suggestion here in extension.xml , this automatically makes that top level base directory folder inside the zip and then the module/ folder shows inside that. So the user doesn't have to!

[tfmorris]

Suggested change

	<includeBaseDirectory>false</includeBaseDirectory>
	<includeBaseDirectory>true</includeBaseDirectory>

Thanks for finding that, @thadguidry. The default base directory will be the versioned artificat ID (so something like openrefine-sample-extension-0.0.1) which I think is a good choice, rather than overriding it. openrefine-sample-extension is kind of verbose, but, whatever we choose, we should use consistently throughout.

[thadguidry]

Ugh, not completely fixed... hmm.

1. OpenRefine starts up just fine after I extract my refine-groovy-1.0.zip directly into the webapp/extensions folder. Great!
2. I noticed that this setup has a index.vt file in module folder ? Seems the extension is serving a page at https://127.0.0.1:3333/extension/refine-groovy

3. But extension "Groovy" as an expression language now does not show up in the dropdown as before when I was bundling the extension into OpenRefine.

Any troubleshooting ideas? Is this still an Assembly issue or not?

[tfmorris]

I think this looks pretty close. I'll go ahead and commit Thad's suggestion (minus the baseDirectory override) and a few naming consistency fixes and we can iterate from there on any additional cleanups.

[tfmorris]

Suggested change

	<description>Example extension provided for demonstration purposes</description>
	<description>Example extension provided for demonstration purposes</description>
	<description>Sample OpenRefine extension provided for demonstration purposes</description>

Let's be consistent with terminology

[tfmorris]

Suggested change

	<includeBaseDirectory>false</includeBaseDirectory>
	<includeBaseDirectory>true</includeBaseDirectory>

Thanks for finding that, @thadguidry. The default base directory will be the versioned artificat ID (so something like openrefine-sample-extension-0.0.1) which I think is a good choice, rather than overriding it. openrefine-sample-extension is kind of verbose, but, whatever we choose, we should use consistently throughout.

[tfmorris]

Let's merge this and use it as the starting point to refine things from.