Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip admonition for Wikidata Help:Dates #364

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

thadguidry
Copy link
Member

@thadguidry thadguidry added the documentation About the user manual or technical documentation label Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for openrefine-website ready!

Name Link
🔨 Latest commit e71b56e
🔍 Latest deploy log https://app.netlify.com/sites/openrefine-website/deploys/66d66e8fe7216800089ae009
😎 Deploy Preview https://deploy-preview-364--openrefine-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tfmorris tfmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are only two legal values for calendar, perhaps we can just list them near line 224-224 instead of redirecting the user. The Wikidata pages says:

Currently two calendar models are supported: proleptic Gregorian calendar (Q1985727) and proleptic Julian calendar (Q1985786)

@thadguidry
Copy link
Member Author

Hi @tfmorris , I thought about that. But there are Phabricator issues for Wikidata where eventually Date datatypes will get more love and also the documentation improved. There's also corner cases and special handling that is covered in their docs. So I'd rather just direct users to read up on the current Date datatypes on Wikidata's official help pages, which are actually quite hard to find just navigating around and often missed.

@wetneb
Copy link
Member

wetneb commented Sep 2, 2024

It feels weird to me to have a "See also" block at the beginning of the subsection. If it's "see also", it makes more sense to me to have this at the end of this subsection, so that it complements the main content.

@wetneb wetneb merged commit b03f855 into master Oct 22, 2024
4 checks passed
@thadguidry thadguidry deleted the thadguidry-patch-1 branch October 23, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation About the user manual or technical documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants