-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two extensions developed by RefinePro #260
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for openrefine-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Should the attribution be to the RefinePro forks or the original FAIRplus repos (e.g. https://github.com/FAIRplus/OpenRefine_Authenticator)? They appear to have been contributed by Novartis (NIBR). |
Thanks for adding them @wetneb . RefinePro was contracted by NIBR to develop extensions, which were then released via FAIRplus. RefinePro added more details to the readme and ported open issues when forking the FAIRplus repositories. It is more likely that any new tickets or pull requests will receive attention on the RefinePro repositories. |
Personally, I would say that the most actively maintained GitHub repository of a project should not be marked as a fork of another one, but as an independent one. You can convert a fork into a non-fork repository by making a request to GitHub's support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be polite to acknowledge the funder & donor, unless they prefer to remain anonymous, but regardless, I strongly object to these extensions being promoted until their license violations are corrected. They contain entire modules of OpenRefine code, copied verbatim, without any of the required license notices.
For example the only differences in HttpClient.java are changing the package name and adding a single line (although it's also missing all the bug fixes we've made since it was copied).
It's a valid point, but I would assume good faith here and avoid to scare away the extension author from interacting with the OpenRefine project. I am glad they wrote an extension for OpenRefine and want to encourage them to do more of that. Looking at the
So I would suspect it's just a lack of familiarity with the concept of license header and the importance to retain them. I think it should be easy to fix. |
I wasn't aware of them but @magdmartin pointed me to them in a call. I think they are worth listing even though they are targeting a fairly old version.