Simplify release process by generating artifacts in the CI #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetneb
force-pushed
the
release_workflow
branch
from
40e9ad9
to
686183f
Compare
This was referenced Aug 9, 2024
Adopt "conventional commits" message style and release-please workflow
Wikidata/Wikidata-Toolkit#900
Open
sebastian-berlin-wmse
requested changes
Sep 10, 2024
.github/workflows/maven.yml
Outdated
| asset_name: openrefine-commons-$VERSION_STRING.zip | ||
| asset_content_type: application/zip | ||
|
|
||
|
|
There was a problem hiding this comment.
Superfluous newline.
.github/workflows/maven.yml
Outdated
| with: | ||
| upload_url: ${{ steps.get_release_upload_url.outputs.upload_url }} | ||
| asset_path: ./target/openrefine-commons.zip | ||
| asset_name: openrefine-commons-$VERSION_STRING.zip |
There was a problem hiding this comment.
Replace value with: openrefine-commons-${{ env.VERSION_STRING }}.zip.
Apparently using bash env variables doesn't work here. This will just call the file
openrefine-commons-VERSION_STRING.zip. See the difference in the releases. "test" is this version and "test2" is with the proposed change.
sebastian-berlin-wmse
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When @sebastian-berlin-wmse did the last release I observed that the process was quite complicated. I think it's worth simplifying, so this is a small step towards that, inspired by the setup we have in the OpenRefine repo. It removes the need to generate the release artifact and upload it to the GitHub release.
I haven't tested it so I hope it works well for the next release.