Skip to content

Cost estimation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Philip-Turk
Copy link
Contributor

Added code for brute-forced solutions, including cost estimations.

@Philip-Turk
Copy link
Contributor Author

table of cost estimations can be found in cost_tables.txt

Copy link
Member

@fgfuchs fgfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. First, this PR can not be merged automatically. -> 2.
  2. Your branch must branch out of the main branch of the repository you merge it to! Not like this: Screenshot 2025-04-25 at 08-36-38 Network Graph · OpenQuantumComputing_LogicalXMixer · GitHub
  3. This script currently reads more like a prototype or proof of concept than maintainable code. Some key issues:
  • No modular structure (e.g., classes or reusable components).
  • Lacks docstrings, type hints, and consistent naming.
  • Contains deeply nested logic, repeated patterns, and magic constants.
  • Overall hard to read and extend.
    I suggest a refactor with clearer abstractions, documentation, and separation of concerns to improve clarity and reusability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants