35 post api sub task #202
Open
35 post api sub task #202
+390
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tenzinsamten
requested changes
Oct 13, 2025
| from pecha_api.plans.tasks.sub_tasks.plan_sub_tasks_response_model import SubTaskRequest, SubTaskResponse | ||
| from pecha_api.plans.tasks.sub_tasks.plan_sub_tasks_services import create_new_sub_tasks | ||
|
|
||
| sub_tasks_router = APIRouter( |
There was a problem hiding this comment.
start then endpoint as cms/sub-tasks
| ) | ||
| ) | ||
|
|
||
| saved = save_sub_tasks_bulk(db=db, sub_tasks=new_sub_tasks) |
There was a problem hiding this comment.
better naming , saved_sub_tasks
| display_order: int | ||
|
|
||
| class SubTaskResponse(BaseModel): | ||
| data: List[SubTaskDTO] |
There was a problem hiding this comment.
from data to subtasks
tenzinsamten
requested changes
Oct 13, 2025
|
|
||
| oauth2_scheme = HTTPBearer() | ||
|
|
||
| @sub_tasks_router.post("/task/{task_id}/sub-tasks", status_code=status.HTTP_201_CREATED, response_model=SubTaskResponse) |
There was a problem hiding this comment.
Change here and add the task_id as part of SubTaskRequests, the endpoint should be:
@sub_tasks_router.post("", status_code=status.HTTP_201_CREATED, response_model=SubTaskResponse)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Sub tasks api
For more detail click