Update whisper.cc : Add logits to WhisperGenerationResult #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logits to WhisperGenerationResult
Update whisper.cc
sammygrey
changed the title
|
also fixes #1822 |
|
Thank you for your fix. I will merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WhisperGenerationResult was missing return value for logits despite register_whisper having a readonly definition for said logits.
Logits are documented on https://opennmt.net/CTranslate2/python/ctranslate2.models.Whisper.html as being returned when return_logits_vocab is set to True, however, there was no written return value to access them within WhisperGenerationResult if it was set to True.
This fixes issue #1779.