Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-17727: Refactor grpc client #7651

Merged
merged 9 commits into from
Mar 10, 2025
Merged

Conversation

cgorantla
Copy link
Contributor

Enable/disable bsm/nms.inventory modules
Use sessionUtils to eagerly load node and it's children
refactor names/packages, remove unnecessary wrappers, fix logging.

External References

aurang-zeb313
aurang-zeb313 previously approved these changes Mar 7, 2025
Copy link
Member

@aurang-zeb313 aurang-zeb313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgorantla cgorantla marked this pull request as ready for review March 7, 2025 22:40
@cgorantla cgorantla requested a review from aurang-zeb313 March 7, 2025 22:40
@github-actions github-actions bot requested a review from indigo423 March 10, 2025 02:49
@github-actions github-actions bot added the docs label Mar 10, 2025
@github-actions github-actions bot requested a review from indigo423 March 10, 2025 13:29
Copy link
Contributor

@naeem-afzal naeem-afzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@indigo423 indigo423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgorantla cgorantla merged commit 8e27bbd into foundation-2024 Mar 10, 2025
18 checks passed
@cgorantla cgorantla deleted the cg/jira/NMS-17727 branch March 10, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants