Add test for SHGEMM #5499
Add test for SHGEMM #5499
Conversation
| #define SGEMV BLASFUNC(sgemv) | ||
| #define SHGEMV BLASFUNC(shgemv) |
There was a problem hiding this comment.
These shouldn't be necessary as shgemv is tested separately?
| int ret = 0; | ||
| int loop = SHGEMM_LARGEST; | ||
| char transA = 'N', transB = 'N'; | ||
| float alpha = 1.0, beta = 0.0; |
There was a problem hiding this comment.
Given #5485, is it worth setting beta to 1.0 here, or testing both variations? Similarly with alpha, as 1.0 and 0.0 can have faster paths but in-between values usually don't.
I haven't got a good answer to this in the C tests, but we could try adding some Python-based tests with hypothesis or Rust tests with proptest.
There was a problem hiding this comment.
Worth noting we also don't test anything but square, and it'd be nice to sample in the various dimensions - though we could maybe just randomly sample to start with?
There was a problem hiding this comment.
Agree on the variations of alpha and beta, but we need to keep in mind that these test are run on each and every build, so time will become a problem sooner or later, and I think non-trivial dependencies like python or rust are completely out of the question for a default build.
Perhaps it would make sense to put those in a completely separate project similar to BLAS-Tester
Co-authored-by: Christopher Sidebottom <[email protected]>
2 participants
fixes #5497