Skip to content

New tests usm (first 5 from PR 632) #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fel-cab merged 10 commits into from
Nov 3, 2023
Merged

New tests usm (first 5 from PR 632) #780

fel-cab merged 10 commits into from
Nov 3, 2023

Conversation

@spophale
Copy link
Collaborator

@spophale spophale commented Oct 27, 2023

Tested on Summit with clang 18 and gfortran.

Related to #632

@spophale spophale added new test PR that adds new tests 5.0 Related to spec version 5.0 ready PR is ready for review labels Oct 27, 2023
@spophale spophale self-assigned this Oct 27, 2023
@seyonglee
Copy link
Collaborator

seyonglee commented Nov 1, 2023

[Results on Summit]

  • tests/5.0/requires/test_requires_unified_shared_memory_allocatable.F90
    • GCC 13.1.1: Fortran test failed: Program received signal SIGSEGV: Segmentation fault - invalid memory reference.
      0x7fff8c076168 in omp_free
      at /autofs/nccs-svm1_proj/stf010/elwasif/gccbuild/src/gcc/libgomp/config/linux/../../allocator.c:626
    • XL 16.1.1-10: "./ompvv/ompvv.F90", line 111.7: 1515-019 (S) Syntax is incorrect.
    • NVHPC 22.11: Fortran test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_allocatable_map.F90
    • GCC 13.1.1: Fortran test failed: Program received signal SIGSEGV: Segmentation fault - invalid memory reference.
    • XL 16.1.1-10: "./ompvv/ompvv.F90", line 111.7: 1515-019 (S) Syntax is incorrect.
    • NVHPC 22.11: Fortran test passed after applying Felipe's suggestions.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc.c
    • GCC 13.1.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_is_device_ptr.c
    • GCC 13.1.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test failed: Condition anArray[i] != i + 20 failed
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_map.c
    • GCC 13.1.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.

@spophale
Copy link
Collaborator Author

spophale commented Nov 1, 2023

@spophale add NULL tests for all dynamic allocations.

@spophale
Copy link
Collaborator Author

spophale commented Nov 2, 2023

@seyonglee , @fel-cab ready for review.

@seyonglee
Copy link
Collaborator

seyonglee commented Nov 2, 2023

[Updated results on Summit]

  • tests/5.0/requires/test_requires_unified_shared_memory_malloc.c
    • GCC 13.2.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.
    • LLVM 17.0.0: C test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_is_device_ptr.c
    • GCC 13.2.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test passed.
    • LLVM 17.0.0: C test passed.
  • tests/5.0/requires/test_requires_unified_shared_memory_malloc_map.c
    • GCC 13.2.1: C test passed.
    • XL 16.1.1-10: error: expected an OpenMP directive
      #pragma omp requires unified_shared_memory
    • NVHPC 22.11: C test failed: Condition anArray[i] != i + 20 failed
    • LLVM 17.0.0: C test passed.

@fel-cab fel-cab merged commit e13a8db into master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seyonglee seyonglee seyonglee approved these changes

@fel-cab fel-cab fel-cab approved these changes

@andrewkallai andrewkallai Awaiting requested review from andrewkallai

Assignees

@spophale spophale

Labels

5.0 Related to spec version 5.0 new test PR that adds new tests ready PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spophale @seyonglee @fel-cab