Skip to content

Fix: bound invoke() transaction polling with a timeout #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OxDev-max merged 1 commit into from
Jul 31, 2026
Merged

Fix: bound invoke() transaction polling with a timeout #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions sdk/src/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ export const MAINNET: NetworkConfig = {
networkPassphrase: Networks.PUBLIC,
};

const TRANSACTION_POLL_INTERVAL_MS = 1000;
const TRANSACTION_POLL_TIMEOUT_MS = 30000;

export class BaseClient {
protected server: rpc.Server;
protected contract: Contract;
Expand Down Expand Up @@ -66,10 +69,17 @@ export class BaseClient {
prepared.sign(keypair);
const response = await this.server.sendTransaction(prepared);
if (response.status === "ERROR") throw new Error(JSON.stringify(response.errorResult));
// Poll for completion
// Poll for completion, bounded by a wall-clock deadline so a dropped
// transaction or an RPC outage can't hang callers indefinitely.
const deadline = Date.now() + TRANSACTION_POLL_TIMEOUT_MS;
let getResponse = await this.server.getTransaction(response.hash);
while (getResponse.status === rpc.Api.GetTransactionStatus.NOT_FOUND) {
await new Promise((r) => setTimeout(r, 1000));
if (Date.now() >= deadline) {
throw new Error(
`Timed out waiting for transaction ${response.hash} to be included after ${TRANSACTION_POLL_TIMEOUT_MS}ms`
);
}
await new Promise((r) => setTimeout(r, TRANSACTION_POLL_INTERVAL_MS));
getResponse = await this.server.getTransaction(response.hash);
}
if (getResponse.status !== rpc.Api.GetTransactionStatus.SUCCESS) {
Expand Down
Loading