Feature/governance fixes - #555
Merged
OxDev-max merged 5 commits intoJul 28, 2026
Merged
Conversation
…nLedger-Foundation#487, OpenLedger-Foundation#490) - Add DirectCallProhibited and ParameterProposalExpired error variants - Block direct calls to pause, unpause, grant_role, revoke_role, transfer_admin once multisig is configured - Add expires_at field to ParameterProposal struct with PROPOSAL_TTL_LEDGERS expiry - Add expiry checks to vote_parameter_change and execute_parameter_change - Ensure multisig governance provides actual security guarantee (exclusivity) - Ensure parameter proposals cannot accumulate indefinitely
…ion#488) - Add require_valid_risk_score_with_max to shared validation for parameterized risk ceiling - Add governance note to treasury.get_fee_bps indicating governed value takes precedence - Add set_late_penalty_bps and get_late_penalty_bps to financing_pool for governance integration - Add TODO comments showing integration points for access_control cross-contract calls - Infrastructure now in place for parameter governance to affect actual protocol behavior - Contracts can read governed values via access_control when integrated
- Add TODO sync points in risk_registry.add_verifier/remove_verifier for access_control coordination - Document where access_control.grant_role/revoke_role should be called - Align verifier lifecycle with governance role system - Infrastructure ready for unified role management once access_control calls are implemented
|
@aji70 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four critical governance security and consistency gaps across the multisig, parameter governance, and role management systems. Together they close major loops between
governance infrastructure and actual protocol behavior.
Changes
#487 — Enforce multisig exclusivity
#490 — Add ParameterProposal TTL (expiration)
#488 — Wire parameter-governance to real consumers
#489 — Unify role systems (integration points)
Notes
Closes #487, Closes #490, Closes #488, Closes #489