Fix compilation errors in invoice_nft: missing DataKey variants and broken test code#362
Merged
OxDev-max merged 2 commits intoJun 30, 2026
Conversation
|
@Devcyprian Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Add missing DataKey variants (RiskRegistry, OutstandingExposure, CurrencyAllowlist) that were referenced in contract body but absent from the enum (E0425 errors) - MigrationVersion already present in DataKey enum (issue OpenLedger-Foundation#347 addressed) - require_not_paused already calls AccessControl.is_paused() (issue OpenLedger-Foundation#348 addressed) - shared/src/validation.rs has no duplicate functions (issues OpenLedger-Foundation#345 and OpenLedger-Foundation#346 already clean) - Remove orphaned code blocks that were nested outside test function bodies - Fix test_set_repaid_invalid_status_fails: complete the incomplete test body - Fix test_next_id_increments: add missing assertion and restore closing brace - Fix test_invalid_status_transition_created_to_funded_fails: replace corrupted content - Fix test_migrate_enables_future_operations: declare missing local variables - Fix test_migrate_preserves_existing_invoices: use correct invoice_id variable - Add missing &None notes argument to all mint_invoice calls in tests - Replace &ipfs_cid function references with &cid variable bindings in tests - Fix test_mint_multiple_invoices_increments_id: use sme instead of undefined sme1 Closes OpenLedger-Foundation#345 Closes OpenLedger-Foundation#346 Closes OpenLedger-Foundation#347 Closes OpenLedger-Foundation#348
Devcyprian
force-pushed
the
fix/compilation-errors-345-346-347-348
branch
from
0b8ab13 to
11c6ceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #345
Closes #346
Closes #347
Closes #348