Documentation on adding leaflet.css #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @jefffriesen Same deal in this PR. I appreciate the documentation addition but, let's remove the yarn.lock for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common mistake. I've forgot it every time I use leaflet for the first time in a while. Here's some examples:
PaulLeCam/react-leaflet#75
PaulLeCam/react-leaflet#233
This reminds them to import leaflet.css.
Following the contributor guidelines, I added this to the changelog and bumped the package.json version. My previous PR (https://github.com/OpenGov/react-leaflet-heatmap-layer/pulls) should be accepted before this one so the numbering is correct.
I'm happy to change either of these PRs if needed.