Add a parameter to the text feature to limit what gets rendered. #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
text-feature-rendered-zone
branch
from
e66138e to
e8151a4
Compare
aashish24
reviewed
Jun 27, 2018
src/textFeature.js
Outdated
| @@ -60,6 +60,12 @@ var feature = require('./feature'); | |||
| * stroke color. May include opacity. | |||
| * @property {geo.geoColor|function} [style.textStrokeWidth=0] Text stroke | |||
| * width in pixels. | |||
| * @property {number|function} [style.renderedZone] If this is a positive | |||
There was a problem hiding this comment.
@manthey i am not entire sure if the name of the variable truly reflects the intention. Would you be open to call it something like renderThreshold or viewportThreshold or something else?
There was a problem hiding this comment.
Of those, I think renderThreshold would be clearer, or even a longer combination like renderViewportThreshold. Do you have a preference?
There was a problem hiding this comment.
renderThreshold seems good enough for me now. Since we do not use the word viewport otherwise, I would have chosen renderViewportThreshold.
the code LGTM
There was a problem hiding this comment.
Updated to renderThreshold and rebased to current master.
manthey
force-pushed
the
text-feature-rendered-zone
branch
from
d58e155 to
ade9fef
Compare
If specified, this skips rendering text that is outside of the current viewport by a specified distance. If you have very large text or text with offsets, this could fail to render the text. However, in well-formed cases, this can skip rendering text that would not be visible in any case.
manthey
force-pushed
the
text-feature-rendered-zone
branch
from
ade9fef to
95f10c9
Compare
aashish24
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If specified, this skips rendering text that is outside of the current viewport by a specified distance. If you have very large text or text with offsets, this could fail to render the text. However, in well-formed cases, this can skip rendering text that would not be visible in any case.