When available, use the mouse event buttons property. #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox erroneously sets the which value to the left button even when it is not held down. The buttons property is correct for browsers that support it, but Safari doesn't, so we have to fall back to using the which value in that case.
brianhelba
reviewed
Feb 27, 2018
| /* When handling touch events, evt.which can be a string, in which case | ||
| * handle a "button" with that name -- a non-integer string will not | ||
| * evaluate as being between 1 and 3. */ | ||
| if (evt.which && !(evt.which >= 1 && evt.which <= 3)) { |
There was a problem hiding this comment.
Should this be a separate conditional block, whereby one of the other previous conditionals runs with this too?
There was a problem hiding this comment.
It doesn't need to be, as in the touch events where it will get triggered, it can never also be in a mouseup event, and we want it to trigger regardless of the buttons conditional.
|
We can use the tutorials for showing off bugs as well as fixes. For instance: Tutorial link. We should add a three-pane default-editable tutorial to facilitate this (rather then using the Basic Tutorial where some steps are ignored). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox erroneously sets the which value to the left button even when it is not held down. The
buttonsproperty is correct for browsers that support it, but Safari doesn't, so we have to fall back to using thewhichvalue in that case.This fixes #781.