Handle tap touch actions. #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specifically supports styli on iPads.
aashish24
reviewed
Aug 10, 2017
src/mapInteractor.js
Outdated
| /* In some scenarios, we get both a tap event and then, somewhat later, a | ||
| * set of mousedown/mouseup events. Ignore the spurious down/up set if we | ||
| * just handled a tap. */ | ||
| if (m_touchHandler && m_touchHandler.lastEventType === 'tap' && (new Date()).valueOf() - m_touchHandler.lastTime < 1000) { |
There was a problem hiding this comment.
worth wrapping this long line? May be we could have a test for long lines - if makes sense we could allow devs to have length of 79/80 or 120 or not :)
There was a problem hiding this comment.
I don't like having a hard limit on line length. It makes it a pain to put things like reference urls in comments. In this case, I'll wrap the line.
aashish24
reviewed
Aug 10, 2017
aashish24
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically supports styli on iPads.
Update documentation on
mapInteractor.