Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support tiled pixelmaps. #1153

Merged
merged 4 commits into from
Feb 4, 2022
Merged

feat: Support tiled pixelmaps. #1153

merged 4 commits into from
Feb 4, 2022

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jan 19, 2022

This creates a pixelmapLayer that is much like an osmLayer mixed with a pixelmap feature.

This needs:

  • tests
  • a tutorial or example
  • better documentation
  • harden against non-webgl pixelmaps (since those aren't supported)
  • Check if selecting a point returns the correct index
  • Test with a larger array

It would be nice to expose a function that would report the maximum value, but that would be expensive -- it would have to fetch all tiles and operate on each of them.

@manthey manthey force-pushed the tiled-pixelmaps branch 2 times, most recently from a249f19 to 63e1ac2 Compare January 20, 2022 14:27
@manthey manthey force-pushed the tiled-pixelmaps branch 2 times, most recently from 650123c to 1973498 Compare January 20, 2022 15:36
@manthey manthey force-pushed the webgl-pixelmaps branch 2 times, most recently from 3b3c997 to 965c169 Compare January 20, 2022 21:44
@manthey manthey force-pushed the webgl-pixelmaps branch 3 times, most recently from f6ae5c4 to 267b016 Compare January 21, 2022 20:34
@manthey manthey marked this pull request as ready for review January 21, 2022 20:38
@netlify
Copy link

netlify bot commented Jan 22, 2022

✔️ Deploy Preview for opengeoscience-geojs ready!

🔨 Explore the source changes: e1a1e20

🔍 Inspect the deploy log: https://app.netlify.com/sites/opengeoscience-geojs/deploys/61f2fb3c9e419200071dee72

😎 Browse the preview: https://deploy-preview-1153--opengeoscience-geojs.netlify.app

This creates a pixelmapLayer that is much like an osmLayer mixed with a
pixelmap feature.
Base automatically changed from webgl-pixelmaps to master February 3, 2022 22:03
@manthey manthey merged commit eae10f6 into master Feb 4, 2022
@manthey manthey deleted the tiled-pixelmaps branch February 4, 2022 13:44
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@manthey manthey mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants