Skip to content

Porting old fix for issue for StringIndexOutOfBoundsException #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

kamilkrzywanski
Copy link
Contributor

@kamilkrzywanski kamilkrzywanski commented Mar 13, 2025

@velo check and merge it if you agree :)
Fix #986

@velo
Copy link
Member

velo commented Mar 14, 2025

Any hope we can get a unit test?

@kamilkrzywanski
Copy link
Contributor Author

@velo
I don’t have a meaningful reproducer—the reproducer is my project, which consists of tens of thousands of classes, and I don’t have time to track down the culprit.
I forget attach issue, it's not my fix - it's proted from querydsl/codegen#40

@velo velo changed the title Fix for #986 Porting old fix for issue for StringIndexOutOfBoundsException Mar 14, 2025
@velo
Copy link
Member

velo commented Mar 14, 2025

Well, no tests mean this might resurface again

@velo velo merged commit f00bd51 into OpenFeign:master Mar 14, 2025
4 checks passed
@kamilkrzywanski
Copy link
Contributor Author

Yes, but when I copy the class where the exception occurs, it doesn’t happen. A broader context is needed—I’m not sure how much.
Still, I think it's worth the risk to merge without tests, as it could attract Eclipse IDE users to QueryDSL. :)
Maybe @NiklasMehner have some reproducer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting old fix for issue for StringIndexOutOfBoundsException
2 participants