Build system fixes on linux #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly -MT option differrent in gcc
|
@bjonkman could you review these changes to the Simulink API build system? |
andrew-platt
approved these changes
Jan 19, 2023
|
@reos-rcrozier, I'll merge this as soon as GH actions completes. These changes should make no difference to GH since it is just in the create_sfunc.m that isn't run in testing. I'm letting the tests run mostly to see if I can learn anything about why GH actions is failing for us. |
|
OK, thanks! |
|
I rebased this PR and merged. Thanks for contributing, and thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Fixes issues with installing and building on Linux, especially simulink interface
Impacted areas of the software
Build system
Additional supporting information
Installing the C++ interface failed on linux due to a typo in the file named SC.h in CMakeLists.txt I have changed it from SC.H -> SC.h
This problem probably doesn't show up on windows as it's file system is case insensitive
I also fixed an issued with building the simulink S-Function on linux. mex on linux does not use COMPFLAGS, you must use CFLAGS or CXXFLAGS, also the -MT option does something very different in gcc than visual studio C++