Skip to content

Conversation

andrew-platt
Copy link
Collaborator

This is not ready for merging yet.

Feature or improvement description
A few minor bugs were discovered after merging #1932.

  • Wrong name for the ExtLoads module (would show in summary file incorrectly)

During PR #1932, there was some confusion about the use of the t_initial value in the WriteOutputToFile which was introduced while splitting FAST_Solution into multiple routines. The FAST_Library.f90 had been calling the FAST_WriteOutput with the original t_initial which is set to zero, but this would the timestamp in all text files to zero (it did not affect the binary writing). To get around this, the m_FAST%t_global value was used in calling WriteOutputToFile in FAST_Subs.f90. But this approach was incorrect - instead the t_initial from FAST_Library should have been the current time. To reduce confusion going forward, t_initial has been changed to t_now in FAST_Subs where appropriate.

  • change t_initial to calculated t_now in FAST_Library calls to file writing
  • change t_initial to t_now in file writing routines in FAST_Subs for consistency
  • replace m_FAST%t_global with t_now in FAST_Subs::WriteOutputToFile call

Related issue, if one exists

Impacted areas of the software

  • glue code
  • summary files from OpenFAST

Additional supporting information

Test results, if applicable
No test results change with this PR (so far)

@andrew-platt andrew-platt added this to the v4.0.0 milestone Dec 18, 2023
@andrew-platt andrew-platt self-assigned this Dec 18, 2023
@andrew-platt andrew-platt marked this pull request as draft December 18, 2023 18:59
@andrew-platt
Copy link
Collaborator Author

Going to redo this PR. Went the wrong direction with trying to resolve issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant