Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Refactor Info Text Blocks into a Reusable Template #2961

Merged
merged 6 commits into from
Feb 2, 2025

Conversation

Sn0w3y
Copy link
Contributor

@Sn0w3y Sn0w3y commented Jan 13, 2025

  • Extracted the repeated “info storage” content into a single <ng-template> named infoStorageText.
  • Replaced each duplicated block with *ngTemplateOutlet="infoStorageText".
  • Reduced code duplication and simplified future maintenance.

No functionality or styling changes were made beyond consolidating the repeated markup.

@Sn0w3y Sn0w3y changed the title Simplify storagechartoverview.component.html Refactor Info Text Blocks into a Reusable Template Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2961      +/-   ##
=============================================
- Coverage      57.01%   57.00%   -0.00%     
- Complexity      9832     9833       +1     
=============================================
  Files           2280     2280              
  Lines          97642    97642              
  Branches        7082     7082              
=============================================
- Hits           55656    55655       -1     
  Misses         39930    39930              
- Partials        2056     2057       +1     

@Sn0w3y Sn0w3y changed the title Refactor Info Text Blocks into a Reusable Template UI: Refactor Info Text Blocks into a Reusable Template Jan 17, 2025
@sfeilmeier sfeilmeier requested a review from lukasrgr January 18, 2025 19:31
Copy link
Contributor

@lukasrgr lukasrgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for contributing

@lukasrgr lukasrgr requested a review from sfeilmeier January 31, 2025 00:17
@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Jan 31, 2025

Thx for contributing

My Pleasure :)

@sfeilmeier
Copy link
Contributor

@lukasrgr: Bitte nochmal die Lösung der Merge-Konflikte anschauen. Außerdem hat mein "prepare-commit"-Skript noch automatische Änderungen umgesetzt.

@sfeilmeier sfeilmeier requested a review from lukasrgr January 31, 2025 09:11
@sfeilmeier sfeilmeier merged commit 37a2fd8 into OpenEMS:develop Feb 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants