Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClassifierProcess. #2

Open
wants to merge 34 commits into
base: development
Choose a base branch
from
Open

Add ClassifierProcess. #2

wants to merge 34 commits into from

Conversation

chuehlien
Copy link
Collaborator

Add choropleth map classification process.

@aashish24
Copy link
Contributor

@chuehlien is this ready to be reviewed? Seems like travis is failing..

@chuehlien
Copy link
Collaborator Author

@aashish24 this is ready to be reviewed. Thanks!

Copy link
Contributor

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LRTM, will give a it try by running it.

@@ -18,6 +18,8 @@
###############################################################################
import logging
import numpy as np
import pandas as pd
import json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to keep in sync with pep8 style, should we have a line between groups of imports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants