Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System test cleanup #61

Merged
merged 47 commits into from
Mar 1, 2021
Merged

System test cleanup #61

merged 47 commits into from
Mar 1, 2021

Conversation

adamsj-ros
Copy link
Contributor

@adamsj-ros adamsj-ros commented Feb 24, 2021 •
edited
Loading

Description

All changes on system_test_cleanup have been previously reviewed but not all together. This PR is to do a quick review before merging to master.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • CI test
  • local test

Checklist:

  • I have performed a self-review of my own code
  • New and existing system tests pass locally with my changes (when applicable)
  • Any dependent changes have been merged and published in downstream modules

lij-oci and others added 30 commits January 18, 2021 11:24
@lij-oci
RmwAllocateFree
16ee2e5
@lij-oci
init
177bb42
@lij-oci
code review changes
c8d7aae
@lij-oci
typo
8c2b3f5
@adamsj-ros
Merge pull request #53 from lij-oci/rmw_allocate_free
12d2ae7 
RmwAllocateFree
@adamsj-ros
Merge pull request #55 from oci-labs/master
c683d11 
merge master back to system_test_cleanup post CI repair
@lij-oci
node, publiser
ed6a198
@lij-oci
Merge branch 'system_test_cleanup' into node
a70c4d6
@adamsj-ros
Update azure-pipelines.yml
21425d3 
commenting RPC CI tests
@lij-oci
code review changes
2877e0d
@lij-oci
code review changes2
dd95cd2
@lij-oci
Merge pull request #56 from lij-oci/node
6920785 
Node, publisher
@lij-oci
subscriber
1a5a4d1
@lij-oci
gid
f33cbf4
@lij-oci
code review changes
1a0c286
@lij-oci
code review changes2
590c813
@lij-oci
Merge pull request #57 from lij-oci/subscription
db93c80 
Subscription
@lij-oci
service related changes
6ef3e49
@lij-oci
remove unwanted dependencies
c78d74a
@lij-oci
node name and namespace
f967509
@lij-oci
names_and_types_helpers
0c5fd9e
src, cmake, package, and include paths switched
0e66e49
switch defines
4fad13f
@lij-oci
remove shared_functions.hpp
d54ea6a
separate hpp template from other functions interface
25b0319
cleanup comments
63ff2c6
@lij-oci
remove opendds_include.hpp
48c60c9
@adamsj-ros
Merge pull request #59 from adamsj-oci/combine_packages
2f5b341 
Combine rmw_opendds_cpp and rmw_opendds_shared_cpp packages
@lij-oci
merge with combining packages
2e33534
Merge branch 'system_test_cleanup' into service
bcc22b8
lij-oci and others added 16 commits February 22, 2021 15:21
@adamsj-ros adamsj-ros marked this pull request as ready for review March 1, 2021 15:53
@adamsj-ros adamsj-ros requested a review from lij-oci March 1, 2021 15:53
adamsj-ros
adamsj-ros commented Mar 1, 2021
View reviewed changes
@adamsj-ros adamsj-ros merged commit bab7b75 into master Mar 1, 2021
@adamsj-ros adamsj-ros deleted the system_test_cleanup branch March 1, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lij-oci lij-oci lij-oci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsj-ros @lij-oci