Release 2.1 changes #34
Merged
+476
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ECCurve` bitlength computation
|
Thank you @dufkan for this significant PR. I added only minor comments which are non-blocking for merge - please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several enhancements and bug fixes, including support for the curve
Wei25519, point existence validation during decoding withfromX, and extended modular size support (up to 4k for compatible smartcards).Changes
shiftLeft)Wei25519(a curve isomorphic toCurve25519, tested on JCOP4 P71)isQuadraticResidue)fromXnow returns true if such a point exists