Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some Symfony upgrade leftovers #71

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Address some Symfony upgrade leftovers #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70f4418
Remove unused .env.* files
MKodde Aug 28, 2024
401d328
Inject the DeprovisionApiFeature enabled flag
MKodde Aug 28, 2024
78e9062
Rename the password hasher to target InMemoryUser
MKodde Aug 28, 2024
a63436b
Update CHANGELOG
MKodde Aug 28, 2024
27c96bc
Update Composer dependencies
MKodde Aug 28, 2024
b6a7d19
Config Monolog like the other Stepup apps
MKodde Aug 28, 2024
1e989bd
Address CodeStyle issues
MKodde Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .env.dist
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions .env.test
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
/vendor/
/web/bundles/
/.idea
.env
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not use .env files, but use the more traditional parameters.yaml way of configuring app parameters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? Cant hurt to leave it there and prevent potential credential leaks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could leave it, but makes little sense if we do not eval/use them.

docker-compose.override.yml
/phpunit.xml.dist

Expand All @@ -23,9 +22,6 @@ docker-compose.override.yml
###< phpunit/phpunit ###

###> symfony/framework-bundle ###
/.env.local
/.env.local.php
/.env.*.local
/config/secrets/prod/prod.decrypt.private.php
/public/bundles/
/var/
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 1.0.1 .. 1.0.2
- Rename the password hasher to target InMemoryUser
- Inject the DeprovisionApiFeature enabled flag
- Remove unused .env.* files

## 1.0.0
- Upgrade to Symfony 7
- Upgrade to PHP8.2
Expand Down
10 changes: 0 additions & 10 deletions ci/qa/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,16 +310,6 @@ parameters:
count: 1
path: ../../src/OpenConext/UserLifecycle/Infrastructure/UserLifecycleBundle/DependencyInjection/UserLifecycleExtension.php

-
message: "#^Cannot access offset 'deprovision_api' on mixed\\.$#"
count: 1
path: ../../src/OpenConext/UserLifecycle/Infrastructure/UserLifecycleBundle/DependencyInjection/UserLifecycleExtension.php

-
message: "#^Cannot access offset 'enabled' on mixed\\.$#"
count: 1
path: ../../src/OpenConext/UserLifecycle/Infrastructure/UserLifecycleBundle/DependencyInjection/UserLifecycleExtension.php

-
message: "#^Method OpenConext\\\\UserLifecycle\\\\Infrastructure\\\\UserLifecycleBundle\\\\DependencyInjection\\\\UserLifecycleExtension\\:\\:buildGuzzleClientDefinition\\(\\) has parameter \\$config with no type specified\\.$#"
count: 1
Expand Down
Loading