Skip to content

Conversation

@gushil
Copy link
Collaborator

@gushil gushil commented Dec 8, 2025

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Related issues

gushil added 15 commits December 8, 2025 21:08
…ne_from_file_filename, and trigger row handling.
…emplate items and moving create items popup into dropdown button.
…nd hide share button for collections; remove unused AssetPublicButton component
@gushil gushil changed the title [WorkInProgress - DoNotMergeYet] Fix disrespancies with current FD Fixed disrespancies with current (staging/prod) FD Dec 19, 2025
@pkolli0408 pkolli0408 requested a review from Copilot December 23, 2025 20:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes discrepancies between the current codebase and the staging/production Form Designer (FD). The changes primarily focus on renaming "Select Many" to "Select Multiple" throughout the application, implementing new library item routing and creation workflows, refactoring form builder navigation logic, and adding OpenClinica-specific features including consent row validation and external data type handling.

Key changes:

  • Standardized terminology from "Select Many" to "Select Multiple" across UI labels and translations
  • Added new routes and functionality for template creation within library collections
  • Enhanced library sidebar with popover menu for creating different asset types (Question, Template, Collection)
  • Implemented OpenClinica consent row validation and signature field logic

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
kpi/tests/test_mock_data.py Updated test data label from "Select Many" to "Select Multiple"
jsapp/xlform/src/view.rowDetail.coffee Added consent row event handling, signature validation, and new field mixins (oc_description, readonly, calculation, trigger, select_one_from_file_filename)
jsapp/xlform/src/view.row.coffee Added event listener for consent row choice value validation
jsapp/xlform/src/view.choices.coffee Implemented consent row choice value validation with error messaging
jsapp/scss/oc/_oc_overrides.scss Added CSS for capitalizing first letter of asset labels
jsapp/scss/main.scss Imported OpenClinica-specific style overrides
jsapp/scss/components/_kobo.form-builder.scss Restructured form builder header cell styling, moved support URL styles to dedicated class
jsapp/scss/components/_kobo.drawer.scss Changed drawer content padding from 0 to 5px
jsapp/js/router/routerConstants.ts Added new routes for template creation in library
jsapp/js/router/allRoutes.es6 Added route definitions for new template creation paths
jsapp/js/mixins.tsx Enhanced library parent-child relationship handling in file upload logic
jsapp/js/i18nMissingStrings.es6 Updated translation string from "Select Many" to "Select Multiple"
jsapp/js/formbuild/containers/KoboMatrix.es6 Updated matrix type labels and comments from "Select Many" to "Select Multiple"
jsapp/js/editorMixins/editableForm.es6 Refactored save/back button text logic and navigation for library items with parent collections
jsapp/js/constants.ts Updated question type labels: "Number" to "Integer", "Select Many" to "Select Multiple"
jsapp/js/components/projectDownloads/projectExportsCreator.es6 Updated export dialog label from "Select Many" to "Select Multiple"
jsapp/js/components/modalForms/libraryAssetForm.es6 Conditionally hide form fields for collection asset type
jsapp/js/components/library/myLibrary.scss Fixed CSS selector specificity for all-tags toggle button
jsapp/js/components/library/librarySidebar.es6 Replaced simple "new" button with popover menu offering multiple creation options and file upload
jsapp/js/components/library/assetRoute.es6 Removed AssetPublicButton component from asset route
jsapp/js/components/formEditors.es6 Added initialization logic for new template creation routes
jsapp/js/components/assetsTable/assetsTableRow.tsx Added action buttons conditionally, added rename collection button, added CSS classes for styling
jsapp/js/components/assetsTable/assetsTable.tsx Added "header" CSS class to table column headers
jsapp/js/components/assetsTable/assetsTable.scss Added capitalize utility class, modified row background color and action column width/alignment
jsapp/js/components/assetsTable/assetActionButtons.tsx Commented out multiple action buttons, modified collection-specific button visibility and labels

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkolli0408
pkolli0408 previously approved these changes Dec 23, 2025
@pkolli0408 pkolli0408 dismissed their stale review December 23, 2025 20:45

Need to make changes to PR upon a second look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants