Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tenable Vuln Management] fix: inconsistent pagination section presence in response api should be handled gracefully #3546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Tenable Vuln Management] fix: inconsistent pagination section presence in response api should be handled gracefully #3546

wants to merge 1 commit into from
+10 −2

Conversation

flavienSindou
Copy link
Contributor

Proposed changes

  • Modify code not to enforce pagination key presence in response.
  • add a warning log indicating response format seems incoherent.
  • include response available keys in the warning log.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

https://www.notion.so/filigran/Tenable-Vuln-Management-Tenable-Breaking-API-Changes-1a48fce17f2a807e8275fd416f7df756?pvs=4#1a48fce17f2a81a89dd9c6d4bd373a69

@flavienSindou flavienSindou added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team critical use to identify critical bug to fix ASAP labels Mar 3, 2025
@flavienSindou flavienSindou self-assigned this Mar 3, 2025
@flavienSindou flavienSindou linked an issue Mar 3, 2025 that may be closed by this pull request
[Tenable Vuln Management] : Inconsistent "pagination" presence in API response should be handled gracefully #3544
Open
Powlinett
Powlinett approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powlinett Powlinett Powlinett approved these changes

@Megafredo Megafredo Awaiting requested review from Megafredo

@pdamoune pdamoune Awaiting requested review from pdamoune

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@flavienSindou flavienSindou

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tenable Vuln Management] : Inconsistent "pagination" presence in API response should be handled gracefully
2 participants
@flavienSindou @Powlinett