Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tenable Vuln Management] - fix: Unhandled CPE URI format should be skipped #3545

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Tenable Vuln Management] - fix: Unhandled CPE URI format should be skipped #3545

wants to merge 2 commits into from
+38 −2

Conversation

flavienSindou
Copy link
Contributor

Proposed changes

  • Skip unhandled CPE URI format with a warning log
  • Add unit test relative to this issue

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

https://www.notion.so/filigran/Tenable-Vuln-Management-Tenable-Breaking-API-Changes-1a48fce17f2a807e8275fd416f7df756?pvs=4#1ab8fce17f2a8004b488da72420fbae9

@flavienSindou flavienSindou linked an issue Mar 3, 2025 that may be closed by this pull request
[Tenable Vuln Management] p-cpe URI format not handled (only cpe one) #3543
Open
@flavienSindou flavienSindou self-assigned this Mar 3, 2025
@flavienSindou flavienSindou added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team critical use to identify critical bug to fix ASAP labels Mar 3, 2025
@flavienSindou flavienSindou changed the title Bug/3543 tenable vuln management p cpe uri format not handled only cpe one [Tenable Vuln Management] - fix: Unhandled CPE URI format should be skipped Mar 3, 2025
Powlinett
Powlinett approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear bug fix and tests pass ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powlinett Powlinett Powlinett approved these changes

@Megafredo Megafredo Awaiting requested review from Megafredo

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@flavienSindou flavienSindou

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tenable Vuln Management] p-cpe URI format not handled (only cpe one)
2 participants
@flavienSindou @Powlinett