Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pynxtools #567

Merged
merged 33 commits into from
Apr 4, 2025
Merged

Update pynxtools #567

merged 33 commits into from
Apr 4, 2025

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Mar 24, 2025

Update Nexus config to newest release

rettigl added 22 commits January 16, 2025 16:43
@rettigl
split off metadata class, and first version if elabFTW metadata retri…
e41a2b1 
…ever
@rettigl
sort metadata
3a32112
@rettigl
add user information
862bc78
@rettigl
fixup metadata
d8cce46
@rettigl
fix tests
94166fc
@rettigl
remove pump beam section if pump closed
8186e9a
@rettigl
use default config dir also for user config
dffa6d1 
find .env files also in system config
@rettigl
change to config_v1.yaml
ac18011
@rettigl
add mock tests for metadata retrieval
5f00201
@rettigl
Merge remote-tracking branch 'origin/v1_feature_branch' into mpes_ela…
3cab84e 
…b_metadata
@rettigl
add additional tests
9089964
@rettigl
always store config
d7e182f
@rettigl
fix docs
b014c18
@rettigl
fix warning messages
bcefdfb
@rettigl
fix tests to not overwrite .env file
74128c2
@rettigl
allow coverage report for config module
cf2abc6
@rettigl
Merge remote-tracking branch 'origin/main' into mpes_elab_metadata
79547d3
@rettigl
fix beam status
935dfeb
@rettigl
allow disabling copy tool
9bc2f8b
@rettigl
add pump2, and fix polarization and pump status conversion
2289c9c
@rettigl
also remove source_pump if not applied
4b51a5d
@rettigl
don't add field if not found in epics archiver
037dfb3
@rettigl rettigl changed the base branch from main to mpes_elab_metadata March 24, 2025 11:21
@rettigl rettigl requested a review from zain-sohail March 25, 2025 07:42
@rettigl rettigl mentioned this pull request Mar 25, 2025
Merged
@rettigl
Copy link
Member Author

rettigl commented Mar 25, 2025

@zain-sohail this updates the Nexus config files for the updated NXmpes definitions (they are becoming part of the official NeXus standard now, and have been revised to some extend).

@rettigl rettigl changed the base branch from mpes_elab_metadata to main March 25, 2025 08:25
@rettigl
Copy link
Member Author

rettigl commented Mar 25, 2025

This includes changes from #551 so that should be merged first.

@rettigl rettigl changed the base branch from main to mpes_elab_metadata March 25, 2025 08:35
@rettigl
Copy link
Member Author

rettigl commented Apr 3, 2025

@zain-sohail can you review this so we can merge it and fix the failing tests?

zain-sohail
zain-sohail approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay. I did take a look before but forgot to approve.

@rettigl rettigl deleted the branch main April 4, 2025 22:05
@rettigl rettigl closed this Apr 4, 2025
@rettigl rettigl reopened this Apr 4, 2025
@rettigl rettigl changed the base branch from mpes_elab_metadata to main April 4, 2025 22:09
@rettigl rettigl merged commit 840a8d9 into main Apr 4, 2025
5 checks passed
@rettigl rettigl deleted the update_pynxtools branch April 4, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rettigl @zain-sohail