Skip to content

docs(config): update configuration drop in with doc comments - #122

Merged
synackd merged 5 commits into
mainfrom
seantronsen/rpm-conf-ux
Sep 10, 2026
Merged

docs(config): update configuration drop in with doc comments#122
synackd merged 5 commits into
mainfrom
seantronsen/rpm-conf-ux

Conversation

@seantronsen

@seantronsen seantronsen commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description

Updates the configuration to include doc-comments and be more inline with the recent UX ideologies present in the PRs listed below, without modifying the source to use a dedicated config file:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen marked this pull request as ready for review September 10, 2026 16:18
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>

@synackd synackd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just requesting a bit more description on the Postgres options to match the good comments below.

Comment thread packaging/common/systemd/smd.container.d/10-defaults.conf
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen requested a review from synackd September 10, 2026 16:45
@synackd synackd changed the title update configuration drop in with doc comments docs(config): update configuration drop in with doc comments Sep 10, 2026
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@synackd

synackd commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Changing title to follow conventional commit format for squash merge.

Comment thread packaging/common/systemd/smd.container.d/10-defaults.conf
Comment thread packaging/common/systemd/smd.container.d/10-defaults.conf
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen requested a review from synackd September 10, 2026 17:21

@synackd synackd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪨

@synackd
synackd merged commit 228949b into main Sep 10, 2026
11 checks passed
@synackd
synackd deleted the seantronsen/rpm-conf-ux branch September 10, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants