Repository navigation
Support validating signatures on GitHub webhook - #123
Merged
Merged
Conversation
Cadair
added this pull request to stack #124
September 23, 2026 14:10
Cadair
force-pushed
the
webhook-security
branch
from
September 23, 2026 14:41
1342ffd to
d544937
Compare
Cadair
force-pushed
the
webhook-security
branch
2 times, most recently
from
September 23, 2026 20:19
c30c9cc to
d7a149e
Compare
Cadair
force-pushed
the
webhook-security
branch
from
September 23, 2026 20:34
d7a149e to
51d8572
Compare
Cadair
marked this pull request as ready for review
September 23, 2026 20:35
astrofrog
approved these changes
Sep 28, 2026
astrofrog
left a comment
astrofrog
left a comment
Collaborator
There was a problem hiding this comment.
This also seems ok to me - Claude suggested the same authentication pattern could be followed for CircleCI if we wanted, but this is something that was missing before anyway so we can just add that in future.
Member
Author
Unfortunately I don't think we can. The reason is that this webhook secret is managed by the person who hosts baldrick and creates the GitHub app. For CircleCI, each repo has to specify their own secret, so at least for Giles it wouldn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was heavily helped out by an LLM, but I've now gone over it carefully and it looks like a solid security improvement.