Allow direct CLI invocations to use similar code to GeneratorService.cmd() #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cker. Previously, PassThroughService.cmd() was missing the --user flag, causing generated files to be owned by root (UID 0:0) instead of the current user.
Member
|
thanks for the PR would it be possible to add a test or 2 covering this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes PassThroughService.cmd() pass a --user command similarly to GeneratorService.cmd()
openapi-generator-cli/apps/generator-cli/src/app/services/generator.service.ts
Line 232 in cd66bf1
In my build environment, this fixes file ownership issues when using direct CLI invocations with Docker.
The index.ts written by the CLI generator is owned by root user, when using
The current workaround is to write it into the openapitools.json as a generator and do
which takes the code path which passes in --user and therefore produces user owned output files.